Gary Gregory
Gary Gregory
> This needs a test case to prevent regression. I should be able to update the PR in the next couple of days I hope (traveling).
Hello @zjzhu-hub Thank you for your PR. This risks a regression unless you update the unit test to check your main changes works.
Needs Apache Infra.
You really need to build the project locally before you create the PR, see the Javadoc errors. Aside from that, I'm starting to think that this is really making the...
I'm not sure what Jenkins has to do with this. In any case, you can see the failure here: https://github.com/apache/commons-lang/actions/runs/3119069043/jobs/5058792919 ``` Error: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:javadoc (create-javadoc-jar) on project...
97 files changed... I should be able to take a look over the weekend.
This PR has no matching tests.
You need to think about how to avoid regressions in case the change is reverted. IOW, in this case, you should get a compilation error. You'll probably want a comment...
I'll take a look this weekend...
This change needs approval on the Apache Infra side to actually run to completion.