Liu Guangyuan (Gary)

Webhook scheduler plugins should return reason when filtering out clusters

1

Currently, there's no `Reason` field in the plugin's response structs. We have added reason reporting in #231 and the reasons reported by built-in filter plugins would get reported in an...

`pkg/util/annotation` and `pkg/util/finalizers` should use `metav1.Object` instead of `pkgruntime.Object` for more ergonomic annotation handling

5

`k8s.io/apimachinery/pkg/runtime.Object` does not have `GetAnnotations` and `SetAnnotations` methods. As a result the annotation util functions in `pkg/controllers/util/annotation/annotation.go` resort to calling `meta.Accessor(obj)` to convert the object. But `meta.Accessor(obj)` returns an error...

`FederatedObject.spec.template` should have type `map[string]interface{}`?

3

`FederatedObject.spec.template` is currently of type `k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1.JSON` which stores the raw json bytes. This type was used because `controller-gen` refuses to implement support for `map[string]interface{}` fields for CRD generation as discussed...

`readyz` should reflect `InformerManager` and `FederatedInformerManager`'s cache sync status

3

`InformerManager` and `FederatedInformerManager` manage informers for the host and member clusters, respectively, based on `FederatedTypeConfig`s. For each `FederatedTypeConfig`, the managers start an informer for the corresponding type. If the informer...

Currently constants are defined in a couple of places: - `pkg/controllers/common/constants.go` - controller's own package - `pkg/util` packages We should organize them so they are more maintainable. When organizing, we...

The code in the two packages are virtually identical except for the types they handle. Can we combine them, probably using generics?

The unused functions are legacy we inherited from KubeFed. We should verify if we still need them and remove them as needed.

At the time of creating this issue, we only support status aggregation for Deployments. - [ ] StatefulSet - [x] Job - [x] Pod - [ ] CronJob - [...

Replace `pkg/client/generic` with dynamic client from `client-go`

1

`pkg/client/generic` is legacy we inherited from KubeFed. It is an unnecessary layer of abstraction and has different usage patterns from `client-go`'s dynamic client. We'd like to standardize all clients to...

Replace `github.com/pkg/errors` with `fmt`?

2

The former has not been maintained since 2021. The latter is not a complete replacement of the former, because the former adds stack traces to errors. However, we are not...