Liu Guangyuan (Gary) comments

Results 7 comments of


                                            Liu Guangyuan (Gary)

Suggestions for move cursor when line wrapped

In Vim, `gj` and `gk` will move to the next visual line, which is what OP wants. However, it does not seem to work in XVim: https://github.com/XVimProject/XVim2/issues/44

Replace `pkg/client/generic` with dynamic client from `client-go`

All packages in `pkg/client` are generated except `pkg/client/generic`. After `pkg/client/generic` is removed, we should rename `pkg/client` to something like `pkg/generated` to better reflect its status.

`FederatedObject.spec.template` should have type `map[string]interface{}`?

> How often do we need to unmarshal the template? It saves the cost of deserializing them every time federated object is updated (especially status-only updates), and it reduces memory...

`pkg/util/annotation` and `pkg/util/finalizers` should use `metav1.Object` instead of `pkgruntime.Object` for more ergonomic annotation handling

@kevin1689-cloud Hi! The major refactor has been completed a while ago. Would you like to continue working on refactoring the annotation util functions as discussed in #144 ?

`pkg/util/annotation` and `pkg/util/finalizers` should use `metav1.Object` instead of `pkgruntime.Object` for more ergonomic annotation handling

@kevin1689-cloud no worries. @z1cheng Thank you for your work on `pkg/util/finalizers`. Would you like to work on `pkg/util/annotations` as well? After that, we can close this issue.

`readyz` should reflect `InformerManager` and `FederatedInformerManager`'s cache sync status

Hi @z1cheng, please feel free to contribute :) We could add the checkers in `createControllerContext` as you suggested, however the informer managers' `HasSynced` method only exposes whether the `FederatedTypeConfig` and/or...

Misconfiguration of a single FTC prevents the FTC controller from progressing

Is this issue still relevant now that we have switched to `InformerManager` to manage the informers? @limhawjia