easy

Results 56 comments of easy

Yes, we would like to support CMake! Unfortunately, we don't (yet) have a lot of CMake experience; so we would very much appreciate some advice from existing CMake users with...

@isaachier that would be awesome! What I would like to see is the directory https://github.com/census-instrumentation/opencensus-cpp/tree/master/examples/grpc split out into its own repo, with a CMake setup that pulls in opencensus-cpp and...

> do you want opencensus-cpp to have its own CMake build as well Yes, absolutely. I'm sorry I wasn't clear on this point. > Does opencensus-cpp have a preference for...

For the time being, what I'd like is a bazel-like approach where OpenCensus C++ (and also Abseil!) are built into the final RPC server binary, and NOT installed like `/usr/local/lib/libabsl.so.1.2.3`...

Does gRPC use `add_subdirectory`? Is it consumed the same way?

No update, sorry. :( I'm still watching https://github.com/abseil/abseil-cpp/issues/38 to see how abseil resolves this. The only library required for core OpenCensus functionality (stats and trace) should be abseil. For e.g....

I've made some progress on a prototype of this. Give me a couple of days and I'll roll a PR.

I have a prototype of a CMake build system. If you're interested in this, please take a look. A good place to start is this out-of-tree example: ```shell git clone...

The child inherits the parent's trace options here: https://github.com/census-instrumentation/opencensus-cpp/blob/2c2e4c764755b54181a9649adf51e6fe65678ec0/opencensus/trace/internal/span.cc#L78 The sampler is called later (L83) if the parent wasn't sampled. Does this help?