easy
easy
The approach in `cmake/Findabseil.cmake` doesn't seem right to me: we shouldn't be enumerating build targets inside of abseil. @coryan, what do you think? Especially as a consumer of opencensus-cpp as...
@meastp: Would you like to split out "Replace OPENCENSUS_INCLUDE_DIR with CMAKE_SOURCE_DIR" into its own PR? (and please convert to Unix line endings) If that doesn't break an out-of-tree example, I'd...
@meastp: Regarding the out-of-tree example, I've updated https://github.com/census-ecosystem/opencensus-cpp-example to have a CMake version of the build system. Feel free to use that for testing from the point of view of...
Regarding https://stackoverflow.com/questions/44990964/how-to-perform-cmakefind-package-at-build-stage-only - this seems a little odd, but IMO much less bad than enumerating all of our dependencies' targets. What do other folks think? @coryan? @fancl20? @isaachier?
> you should let folks configure how the dependencies are found. I agree with this. How about if we add a knob via `set()` so the user can choose between...
Thanks for the pointer, @isaachier ! CMake 3.11 looks a bit too new today but that will change: https://packages.debian.org/search?keywords=cmake Good to know we can just import the implementation though. >...
@meastp: In the interest of keeping things moving, would you like to split out the install (+ hdrs) part of this PR into its own PR, while we keep discussing...
@bogdandrutu Short term: waiting for headers and MSVC changes to be split out. Longer term I'd like to see https://github.com/census-instrumentation/opencensus-cpp/pull/256#issuecomment-447215780 implemented.
Example usage, doesn't even require a VM: ``` socat VSOCK-LISTEN:12345 EXEC:"/usr/lib/openssh/sftp-server",nofork ./sshfs -o vsock=2:12345 unused_host: ./tmp ``` (CID=2 means loopback) Most of the performance gain is from reducing the amount...
> what sits on the other end of a vsock and implements the server-side protocol? Is it the kernel, or another userspace program? For my use-case, it will be the...