easy

icon location When you press this button, it says "that was easy."

Results 56 comments of easy

Child Span doesn't inherit Parent's sampling decision?

IIUC: if the parent is sampled then the child is sampled.

Child Span doesn't inherit Parent's sampling decision?

If you want to avoid "inflationary" sampling of child spans, set the sampling probability to zero. Children of sampled parents will still get sampled.

What is the recommended way to gracefully shutdown?

Currently we sleep to let the stats aggregation and exporting happen, which isn't ideal.

What is the recommended way to gracefully shutdown?

I've been thinking about it but I don't have a good proposal yet. Related discussions: * https://github.com/census-instrumentation/opencensus-specs/issues/152 for flushing stats * https://github.com/census-instrumentation/opencensus-specs/issues/126 for flushing traces

What is the recommended way to gracefully shutdown?

I'm afraid not. I'm very limited in how much time I can spend on OpenCensus. Check out https://github.com/open-telemetry/opentelemetry-cpp/

Change the Stackdriver exporters' Register() to return Status.

I think these functions should return `grpc::Status` because almost all of the possible errors come from the RPC stack. The other kind of Status we have in OpenCensus is for...

Implementation of install target in CMake

This is one of the bullet points tracked in #244.

Implementation of install target in CMake

https://github.com/abseil/abseil-cpp/commit/bf29470384a101b307873b26d358433138c857fc - This somewhat large commit contains abseil's implementation of cmake install. We should take this into consideration when we do this for OpenCensus.

Change Span name after starting a span.

cc @SergeyKanzhelev

Change Span name after starting a span.

Enabling sampling after starting a span is mentioned in #218 also. A potential problem I can see is: if sampling_enabled is stored in the SpanContext, and the SpanContext has been...