Tomoya Fujita
Tomoya Fujita
@GauravKumar9920 thank you very much, i will be happy to review.
there is a description in release note, https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html#passing-ros-arguments-to-node-actions. it could be also added to documentation such as https://docs.ros.org/en/rolling/Tutorials/Intermediate/Launch/Creating-Launch-Files.html? (because release note is meant to show the change log and difference...
as @clalancette pointed out, we need to add some procedure during devcontainer instantiation. i will come up with fix 🔨
`INFINITE` is rmw dependent definition as below. and ROS 2 just handles that as `INFINITE` but exact digits. - `rmw_fastrtps` to `Fast-DDS` https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/time_utils.cpp#L23-L33 - `Fast-DDS` to `rmw_fastrtps` https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/qos.cpp#L42-L49
@SammyRamone thanks for the contribution, i will take a look at the related PRs.
@SammyRamone does this still need to be a draft?
Can you elaborate a bit why `--net=host` is required to the tutorial? i think it does not have to be using host network interface, but using docker bridge can allow...
@clalancette could you take a look at this? this needs to go in with https://github.com/ros2/demos/pull/649
thank you very much detailed explanation! i would like to ask a couple of questions, - Notification and Status check against the main doc. I do speak Japanese so if...
CC: @MiguelCompany @clalancette @eboasson