ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Add QoS Magic Number note

Open DLu opened this issue 1 year ago • 3 comments
trafficstars

This number needs to be documented.

DLu avatar Feb 02 '24 20:02 DLu

Hey @DLu, can you double check if these values are specific to different DDS implementations?

audrow avatar Feb 15 '24 18:02 audrow

Hey @DLu, can you double check if these values are specific to different DDS implementations?

Honestly, if someone wants to do that they can, but otherwise it just seems like a roadblock to getting better documentation.

DLu avatar Feb 15 '24 22:02 DLu

INFINITE is rmw dependent definition as below. and ROS 2 just handles that as INFINITE but exact digits.

  • rmw_fastrtps to Fast-DDS

https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/time_utils.cpp#L23-L33

  • Fast-DDS to rmw_fastrtps

https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/qos.cpp#L42-L49

fujitatomoya avatar Feb 15 '24 22:02 fujitatomoya