Tomoya Fujita

Results 1221 comments of Tomoya Fujita
trafficstars

> > After checking the code, user-defined QoS by the code will override the QoS settings read from the configuration file. > This is the intended behaviour and it is...

> btw, i think we should add some tutorial and explanation about https://github.com/ros2/demos/tree/rolling/quality_of_service_demo#qos-overrides to https://github.com/ros2/ros2_documentation https://github.com/ros2/ros2_documentation/issues/4549 is follow-up for documentation.

@dhood > Can the demo you linked be used to manipulate topics using system default qos, eg this [topic inside moveit](https://github.com/moveit/moveit2/blob/6454a073d27c4eeb23d4f748364b22f5b072cf92/moveit_ros/planning/planning_scene_monitor/src/planning_scene_monitor.cpp#L1277C1-L1277C62)? I think it can only be used to configure...

this PR includes https://github.com/ros2/rclcpp/pull/2471 with latest code base, so i will close https://github.com/ros2/rclcpp/pull/2471.

even though https://design.ros2.org/articles/actions.html#clientserver-interaction-examples does not specify that feedback messages needs to be delivered before result, all examples tell me result comes to the client after feedback messages. besides, if the...

@mauropasse thanks for your comment! > Feedback and status messages received by the client after the action has finished could (should?) be ignored if the user already knows the action's...

@mauropasse can you also resolve @ahcorde 's comments?

@jmachowinski since you have commented this, what do you think of the current change?

I am not sure how to fix this... but wanted to post the comment for the direction we take... > The "warm up" spin is needed only for entities that...

@tonynajjar @SteveMacenski @doisyg all related PR are merged including backport for jazzy. @jmachowinski thanks for the fix!