Vlad Frolov

Results 251 comments of Vlad Frolov

Just for the history, I believe most if not all of the issues here are related to #84

BigDecimal is opinionated and not defined as borsh type yet, so I will close this PR for now until we absolutely need it (same as #109)

@itegulov Do I understand it correctly that NEAR ABI does not need Borsh Schema anymore and we can close this issue? I feel Borsh Schema does not really work well,...

@westy92 I will be happy to review a pull request. The issue is hypothetical, and you really need to setup yourself into a trouble to exercise it, so given the...

A vector of zero-sized types is pointless in the context of serialization/deserialization in my opinion, so I believe the best thing is to just forbid collections of zero-size elements (https://github.com/near/borsh-rs/pull/136#issuecomment-1561993704)....

@vantessel I believe the original motivation died out and there is currently no champion to implement it. I am happy to review a PR if anyone is ready to contribute...

I think this PR is stalled and is not required anymore, so I am closing it.

~~I believe we should avoid enabling error-prone ways of interaction. We use JSON format to ease reviewing the arguments and we drop the field names, we should better use borsh.~~...

@Bexanderthebex So far we kept this table for 3 months since the time I posted this issue. I think we will keep it for some time more, but I don't...

The idea behind it was to copy-paste the lockup contract as is with minimal modifications, but I agree that might be an overkill to justify pulling the whole near-sdk. It...