Ullrich Praetz comments

Results 51 comments of


                                            Ullrich Praetz

Friflo Position component conflicts with user implementation

This change will not only affect `Position`. Also `Scale`, `Rotation` and `Transform`.

Relations<TRelation> [index] operator sometimes returns the wrong TRelation

Both issues are related to the same problem: `Relations` instances get outdated when adding / removing relations. After adding / removing relations access to `Relations` is invalid. E.g. ```cs entity.AddRelation(new...

Relations<TRelation> [index] operator sometimes returns the wrong TRelation

Added the same runtime assertion in **3.4.1** when deleting the source or target entity of an `ILinkRelation` with `DeleteEntity()`. Reason: `DeleteEntity()` may also remove relations. See tests: https://github.com/friflo/Friflo.Engine.ECS/blob/23738d461e034b298497007f4246f31d2c8f612a/src/Tests/ECS/Relations/Test_Relations.cs#L526

Relations<TRelation> [index] operator sometimes returns the wrong TRelation

hey @ZeromaXHe > I've found some clues that using Relations.[index] you have a # 👁️! There was indeed a bug in the `Relations` indexer. Just fixed it in **3.4.2**. Added...

Recommended to add a new approach where each chunk is processed by a separate thread

The current approach: split a big chunk (thousands of components) into smaller segments. Each segment is processed in a separate thread. In this case multi thread is beneficial. The penalty...

Recommended to add a new approach where each chunk is processed by a separate thread

An example. A query with 10 matching archetypes. Their sizes: ```cs - 1 archetype - 100000 components - 9 archetypes - 10 components var runner = new ParallelJobRunner(4); // 4...

Recommended to add a new approach where each chunk is processed by a separate thread

The current implementation does this: ``` - 1 archetype - 400000 components - 4 archetypes - 100000 components // 400000 components var runner = new ParallelJobRunner(4); // 4 threads 1....

Recommended to add a new approach where each chunk is processed by a separate thread

Thanks, understand. In this case your scheduling would be better, right. But as you mentioned in a general case it is unlikely having this kind of distribution. Factors that have...

SystemGroup (SystemRoot) only calls the first function added to it.

Can you add a perf log after instantiation and `Update()` to see the system hierarchy? Maybe the second system is disabled or an exception is thrown by the first system....

[Feature Request] Extend System Groups

You can pass the ticks via the struct [UpdateTick](https://github.com/friflo/Friflo.Engine-docs/blob/main/api/UpdateTick.md). They are passed as parameter of the method `SystemGroup.Update(UpdateTick tick)`. I you mean something different please show the a Bevy example...