Friflo.Engine.ECS icon indicating copy to clipboard operation
Friflo.Engine.ECS copied to clipboard

Friflo Position component conflicts with user implementation

Open jsBread opened this issue 5 months ago • 5 comments

Just a slight nitpick that because Friflo exposes it's own Position component, it will often require the user to fully qualify the namespace if they want to implement their own Position component. In my case my Position component is double precision, hence not being able to use what Friflo offers.

One workaround on the user side is of course simply to name our Position component differently. But I'm wondering if perhaps Friflo should not offer any component implementations to the user.

jsBread avatar Jul 09 '25 12:07 jsBread

Similar to https://github.com/friflo/Friflo.Engine.ECS/issues/14

DruidOwl avatar Jul 09 '25 15:07 DruidOwl

Right, adding these components was not a good idea. Removing or renaming them may break some users. I now decided to do this. But I don't know when right now.

friflo avatar Jul 09 '25 16:07 friflo

This change will not only affect Position. Also Scale, Rotation and Transform.

friflo avatar Jul 09 '25 17:07 friflo

But I don't know when right now.

Maybe with the next major release (i. e. 4.0.0)? At least it will mark the breaking changes.

DruidOwl avatar Jul 09 '25 21:07 DruidOwl

But I don't know when right now.

Maybe with the next major release (i. e. 4.0.0)? At least it will mark the breaking changes.

Agreed, if we're doing SemVer, then as a breaking change it would bump us to 4.0.0

jsBread avatar Aug 08 '25 01:08 jsBread