Salman Alshamrani

Results 103 issues of Salman Alshamrani

Raised in https://github.com/ppy/osu/pull/18090#issuecomment-1117218050 with brief explanation and discussion in https://github.com/ppy/osu/pull/18090#issuecomment-1118136311. In summary, `ScrollContainer` cannot compute the bounds of a non-loaded target, as it doesn't have a parent yet to inherit...

area:UI
type:reliability
priority:2

Something I found which is outdated by now given the refactors of `TextInputSource`, and which bugged me with its delay on hide (almost feels like the game is slow enough...

area:input
platform:iOS
size/M

![CleanShot 2021-09-04 at 19 37 16](https://user-images.githubusercontent.com/22781491/132102004-6e389107-699d-46b7-89f4-7d82e57b87de.png) Notice the "Multiple Text Sizes" line not having the words aligned on one baseline, while each `SpriteText` implements `IHasLineBaseHeight` and `TextFlowContainer` has the logic...

area:layout
priority:1

![CleanShot 2021-05-23 at 00 08 37](https://user-images.githubusercontent.com/22781491/119240823-0843a100-bb5b-11eb-8960-b037e84fd9bc.png) On testing, `hitcircleoverlay` is never used for sliders unless the circle's texture itself (`sliderstartcircle`/`sliderendcircle`) isn't skinned, in which case `hitcircle` and `hitcircleoverlay` will be...

- Closes https://github.com/ppy/osu/issues/20324 - [ ] Depends on https://github.com/ppy/osu-framework/pull/5421 - [ ] Depends on framework bump Haven't tested this in practice, but should work well. --- ![CleanShot 2022-09-16 at 16...

type:input
type:UX
size/M

### Type Game behaviour ### Bug description Coming from https://github.com/ppy/osu/pull/19413#issuecomment-1238277933, beatmap carousel cards only check `AllBeatmapsUpToDate` to determine whether the update button should be shown, which is not enough in...

type:online
area:song-select

Without this change, Rider would use different codestyle settings and start complaining about it in code analysis. This only started happening on Rider 2022.2.3, but it may have been something...

area:tooling
size/S

```csharp [Test] public void TestResetTabsPreservesSelectionOnLastTab() { AddStep("select item 12", () => simpleTabcontrol.Current.Value = TestEnum.Test12); AddStep("reset tabs", () => { simpleTabcontrol.Clear(); foreach (var item in items) simpleTabcontrol.AddItem(item); }); AddStep("re-select item 12",...

area:UI
priority:2

Coming from https://github.com/ppy/osu/issues/20170, can repro when querying "toby fox" and attaching the cursor of the first page on second request, results may either show: - [`THE WORLD REVOLVING (Camellia Remix)`](https://osu.ppy.sh/beatmapsets/1585092)...

type:api
area:beatmap-listing

Before: https://github.com/ppy/osu/assets/22781491/be64a638-20f7-436f-bc1a-47c0a78bdfd3 After: https://github.com/ppy/osu/assets/22781491/7a550989-7df5-4851-add4-7780237e89e3

ruleset/osu!mania
area:skinning
size/XS