osu icon indicating copy to clipboard operation
osu copied to clipboard

Update button may not show under certain scenarios

Open frenzibyte opened this issue 2 years ago • 0 comments

Type

Game behaviour

Bug description

Coming from https://github.com/ppy/osu/pull/19413#issuecomment-1238277933, beatmap carousel cards only check AllBeatmapsUpToDate to determine whether the update button should be shown, which is not enough in case an online beatmap has a new difficulty or removed an existing difficulty without affecting any difficulty hash.

For the PR's case, this could be resolved by enforcing the update button to be shown when Status == LocallyAvailable, but this could still be a problem if an online beatmap has a new difficulty added, for example.

One envisioned way may be to add an OnlineCount property that's checked with on BeatmapUpdaterMetadataLookup, but that may require server-side changes.

Screenshots or videos

No response

Version

https://github.com/ppy/osu/commit/604fc0fb9745935486f668f0676e60dc89769c0a

Logs

frenzibyte avatar Sep 06 '22 15:09 frenzibyte