Salman Alshamrani

Results 103 issues of Salman Alshamrani

Opening an issue thread because I was concerned whether to use `Passed` or `Rank == F`. It's used in little places, and I would've directly opened a PR to remove...

type:code-quality
area:scoring

### Type Cosmetic ### Bug description Had this one sitting on my local tasks list since I worked on fixing taiko playfield measurements. Not sure what's causing the discrepancy. ###...

ruleset/osu!taiko
area:skinning

- Discussed in https://github.com/ppy/osu/issues/9658#issuecomment-2005767323, resolving one part of the issue. - Closes https://github.com/ppy/osu-framework/issues/1966 When the game is paused, the game input manager has `UseParentInput` set to false for input to...

area:input
size/L

- Closes https://github.com/ppy/osu/issues/9658 - [ ] Depends on #6221 This resolves issue 1 pointed at https://github.com/ppy/osu/issues/9658#issuecomment-2005767323, and together with #6221, will resolve the issue entirely. When the user presses the...

area:input
size/L

Apple recently supported `CADisplayLink` on macOS, starting from macOS 14.0 onwards. According to @smoogipoo, there have been mentions that `CADisplayLink` helps better on frame timing than `CVDisplayLink` does ([which we...

type:performance
platform:macOS

Popped up out of the blue in Rider 2024.1.2: ![CleanShot 2024-05-11 at 22 32 18](https://github.com/ppy/osu/assets/22781491/1826f3fe-b6e3-44ae-b88c-b0dd792105b3)

area:tooling
size/XS

- Part of #22204 Added this to properly give animation to the upcoming "osu!" button (as a proposal, not final). I've also made a dummy `SongSelectV2` screen to pour in...

area:song-select
type:cosmetic
size/L

- Part of #22204 - [x] Depends on #28141 (since `FooterButtonV2` is touched in there) Changed to match animations of `ShearedButton`. Not a good idea to inherit from it since...

area:song-select
type:behavioural
size/L

- [ ] Depends on #28553 for mergability In the new song select screen, when opening mod select, `ScreenFooter` should act as the footer of the overlay, containing buttons like...

type:cosmetic
type:behavioural
size/XXL
area:overlays

Prerequisite for integrating the new `ScreenFooter` component with the existing mod select overlay screens (alongside other sheared overlays). The current mod customisation area is ingrained underneath the footer. When replacing...

type:cosmetic
size/XXL
area:overlay-mod-select