Salman Alshamrani

Results 103 issues of Salman Alshamrani

There is a gesture in my iPad allowing me to take screenshots by swiping from the bottom left corner. On osu!, that position of activating the gesture conflicts with the...

area:input
platform:iOS

Dependency injection happens on the load thread, and resolving bindables require creating a bound copy of the cached bindable. When a drawable is asynchronously loaded, there's a chance for the...

area:bindable
priority:1

This became present while I was working towards fixing sRGB conversion, since I removed `toSRGB` usage in `sh_Blur`, which was the only usage of the global uniform block, therefore SPIR-V...

priority:2
area:renderer-veldrid

Pasting passwords in osu! on iOS gets annoying because of this. I'm seeing this with the 3-tap paste feature, not sure about pasting using hardware keyboard in iPad. Potentially related...

priority:0
platform:iOS

- [ ] Depends on https://github.com/mellinoe/veldrid/pull/506 - [x] Depends on https://github.com/ppy/veldrid/pull/15 - Should (resolve) https://github.com/ppy/osu/issues/23252 - Should (resolve) https://github.com/ppy/osu-framework/issues/5748 ## Preface Since https://github.com/ppy/osu-framework/pull/5508, custom mipmap generation was implemented to reduce...

type:performance
blocked
size/XXL
area:renderer-veldrid
area:renderer-gl

- Addresses https://github.com/ppy/osu-framework/discussions/6463 Opened as draft as it's been mentioned that this breaks front-to-back passes on Android. Probably requires further investigation before merge, but opening it anyway rather than leaving...

type:performance
blocked
area:graphics
size/M

Coming from https://github.com/ppy/osu-framework/issues/5861#issue-1768470004, this PR adds guards against enabling stencil tests when targeting a framebuffer with no stencil attachment. I've had to change the parameter types of the renderer components...

area:graphics
size/L
type:reliability

- [ ] Depends on #5863 (for the `ToPixelFormat` extension) - One other and final step towards resolving https://github.com/ppy/osu/issues/23970 - May result in resolving https://github.com/ppy/osu-framework/issues/5858 (it doesn't on Metal)

size/L
area:renderer-veldrid

With `CADisplayLink`/`CVDisplayLink`, the draw thread is *always* limited to the refresh rate to the display. That's totally correct behaviour, but `GameHost.MaximumDrawHz` needs to reflect that for components like the FPS...

platform:macOS
platform:iOS
priority:1

Recently, a series of pull requests got opened and merged back and fourth to resolve edge cases all revolving around `GenerateItemText`: - https://github.com/ppy/osu-framework/pull/5516 - https://github.com/ppy/osu-framework/pull/5794 - https://github.com/ppy/osu/pull/23858 - https://github.com/ppy/osu-framework/pull/5831 -...

proposal
area:UI
type:reliability