Franck Nijhof

Results 1185 comments of Franck Nijhof

Ref: https://github.com/andrey-git/waqi-async/issues/4 Fix: https://github.com/andrey-git/waqi-async/pull/5

> Hi @frenck - does that mean this will be resolved when 2023.6 exits the beta? My apologies if I'm misunderstanding. It means there is upstream fixes pending that we...

> Because of the current 'out of HA control ' situation it would be best to mark the integration broken in the HA docs. It is a bug, we don't...

Closed the new PR (#95300) and re-opened this one. This is not how it works, if you want to learn more about our review process, please read: Creating new PRs...

> how long is the queue? Long, see the pull request tab. Everything is open source and depended on contributions. This include help with reviews. If you want things to...

I've marked this PR, as the CI is failing which needs to be fixed. Please add the missing test coverage. Please un-draft it once it is ready for review again...

If all assistants are marked as "not exposed", like this one: ![image](https://user-images.githubusercontent.com/195327/235733862-9b460caa-7f00-4c1b-bf12-6206c3b6fb4e.png) Should it be removed from the storage collection instead? The frontend doesn't show this one anymore at this...

> No, in case the user has enabled automatic expose of supported entities, the choice to not expose an entity needs to be stored. In that case, we have a...

> Link to documentation pull request: found in the ESPHome docs @grahambrown11 This needs a PR in that HA docs too. Even though small, it still needs updating of platforms...