Update holidays to 0.24

[arkid15r]

Proposed change

Bump holidays version from 0.21.13 to the latest 0.24. Fix Germany holidays tests (l10n). // I guess more changes may be required to deal with the localized holidays.

The release notes:

• https://github.com/dr-prodigy/python-holidays/releases/tag/v.0.24
• https://github.com/dr-prodigy/python-holidays/releases/tag/v.0.23
• https://github.com/dr-prodigy/python-holidays/releases/tag/v.0.22

Type of change

• [x] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [x] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [x] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @fabaff, @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (workday) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of workday can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign workday Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[arkid15r]

Hey @gjohansson-ST, here is an implementation of language support option for workday sensor holidays.

As it's been my first time experience with config flow please review thoroughly. I bet there is some excessive stuff and/or missing one too.

Thank you!

[gjohansson-ST]

I don't think we should ask for the language. We should just use the local language eg German for Germany, Swedish for Sweden and so on.

[arkid15r]

I don't think we should ask for the language. We should just use the local language eg German for Germany, Swedish for Sweden and so on.

I'm sure that wouldn't be hard to implement.

First of all, I'd like to note that the default/local country's language (if any) has already been used as a default for the new Language field.

I'd also like to point out that as a Home Assistant user I'd benefit more from an ability to select one of the available localizations for a country holidays instead of using non-configurable default value set behind the scenes.

A couple of use case examples:

• some countries have multiple official languages, e.g., Canada where I expect people would want to be able to pick their preferred choice
• when I create a Workday sensor for a country w/ the default language I don't know I'd definitely prefer using one of localizations I'm familiar with instead of the default one (e.g., use en_US or uk instead of sv for Sweden holidays addition/exclusion)

I don't mind simplifying the implementation based on your comment if that's the best/optimal UX for HA users. Could you elaborate on your recommendation a bit -- I'd like to hear more on why in your opinion we shouldn't ask for the language.

Thank you!

[gjohansson-ST]

@arkid15r Maybe it's better to open a new PR given there is now many people subscribed to this PR from your merge (you should rebase instead). Secondly it should still mimic current behavior. Implementation of language option is not bad but should be an option then and in a follow-up PR

[frenck]

I've marked this PR, as the CI is failing which needs to be fixed. Please add the missing test coverage.

Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

[arkid15r]

@arkid15r Maybe it's better to open a new PR given there is now many people subscribed to this PR from your merge (you should rebase instead). Secondly it should still mimic current behavior. Implementation of language option is not bad but should be an option then and in a follow-up PR

@gjohansson-ST I'm closing this out in favor of https://github.com/home-assistant/core/pull/95091 Please review the PR with actionable comments if any.

... the CI is failing which needs to be fixed. Please add the missing test coverage.

@frenck Thanks for pointing out an issue. I understand the proper test coverage concern.