Add romy vacuum integration

[xeniter]

Breaking change

Proposed change

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

Add romy vacuum core integration

ROMY vacuum cleaner homepage: https://www.romyrobot.com

PYPI package: https://pypi.org/project/romy/ PYPI package Source: https://github.com/xeniter/romy/releases/tag/0.0.5 Using latest Version 0.0.5 containing fix that robot returns initialized true even it can't read sensor value(this is the case when the http interface is still locked): https://github.com/xeniter/romy/compare/0.0.4..0.0.5

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/27578
• Link to brand pull request: https://github.com/home-assistant/brands/pull/4413

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [x] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [x] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [x] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[xeniter]

@emontnemery did you take a look at the changes? is everything properly solved?

[xeniter]

closed got not response from reviewer @emontnemery after nearly one month, created new merged with all suggested changes from him under: https://github.com/home-assistant/core/pull/95300

[frenck]

Closed the new PR (#95300) and re-opened this one.

This is not how it works, if you want to learn more about our review process, please read:

https://developers.home-assistant.io/docs/review-process

Creating new PRs (with the same contents) to get re-newed attention, is not acceptable. Please have patience instead. If you want things to move faster, please help review the queue of PRs instead.

Thanks 👍

../Frenck

[xeniter]

Closed the new PR (#93750) and re-opened this one.

This is not how it works, if you want to learn more about our review process, please read:

https://developers.home-assistant.io/docs/review-process

Creating new PRs (with the same contents) to get re-newed attention, is not acceptable. Please have patience instead. If you want things to move faster, please help review the queue of PRs instead.

Thanks +1

../Frenck

how long is the queue?

sorry for the inpatience, was waiting a month for a approve of @emontnemery requestes changes, after three weeks i tried pinging @emontnemery here and contacted him per mail after three weeks

waited a another week -> got no response at all, i know i should be patience and not contact per mail but got no response for 4 weeks?

you @frenck are at same company or? could you ping/reach him? is he still alive?

created new MR only cause of getting no response at all (a simple on vacation for two weeks, or no time next three weeks would be nice, so at least i know the status)

sorry for reopening if it really takes one month+ for reviewing i wasn't aware of that

[frenck]

how long is the queue?

Long, see the pull request tab. Everything is open source and depended on contributions. This include help with reviews. If you want things to go faster, please help out reviewing.

after three weeks i tried pinging

Please don't do that, see also the link I've send you above, there is a section in there on things not to do.

you @frenck are at same company or? could you ping/reach him? is he still alive?

I work full time on Home Assistant, just like Erik. He is still alive, I will not ping him.

created new MR only cause of getting no response at all

That makes no sense, as described above. Please don't do that. Have patience instead.

../Frenck

[xeniter]

I have done a quick initial review.

Please fix the requested changes

thx, committed all requested changes, please double check if they are ok

[home-assistant[bot]]

Hello @xeniter,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 462c8edc0c2a804f8d8a8d612c37b4800122d0c1 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

[home-assistant[bot]]

Hello @xeniter,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• eefded8501697d97adbb7c0e61197366383f3647 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

[edenhaus]

Drafting it as not all requested changes were implemented or commented. Please mark the PR only as ready to review when all requested changes are addressed.

[home-assistant[bot]]

Hello @xeniter,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 4887ee359d74e6eded40ce7f8978de4310fd3682 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

[home-assistant[bot]]

Hello @xeniter,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 982cc2050a33116b89d507f18da5c9bd17a159ef - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

[xeniter]

Drafting it as not all requested changes were implemented or commented. Please mark the PR only as ready to review when all requested changes are addressed.

sorry for that, complete overseen some requests behind a "load more..." button, now all points should be solved, marked it as ready again

[edenhaus]

A PR in draft is considered still in progress and not ready for another review. Therefore, it will not get (any) attention from the reviewers. Please mark it as "Ready to review" when you think we should review it again.

[xeniter]

A PR in draft is considered still in progress and not ready for another review. Therefore, it will not get (any) attention from the reviewers. Please mark it as "Ready to review" when you think we should review it again.

big thx, wanted already to mark it as ready, got somehow interrupted and complete forgot about it later

[xeniter]

We require 100% test coverage for the config flow

added missing testcase, now its 100%

[xeniter]

Something is clearing the review comments when changes are pushed so maybe avoid that if possible

whats gets exactly cleared? how should i avoid push of changes or how can i take care? unfortunate review got quite big and the "load more button" got me tricked already into mark it ready with unresolved points

[allenporter]

Something is clearing the review comments when changes are pushed so maybe avoid that if possible

whats gets exactly cleared? how should i avoid push of changes or how can i take care? unfortunate review got quite big and the "load more button" got me tricked already into mark it ready with unresolved points

Yes, that's what I'm talking about. Look at the GitHub history for this PR. Whatever you are doing is pushing tons of commits. Maybe you are rebasing and force pushing every time? That should be rare

[xeniter]

Something is clearing the review comments when changes are pushed so maybe avoid that if possible

whats gets exactly cleared? how should i avoid push of changes or how can i take care? unfortunate review got quite big and the "load more button" got me tricked already into mark it ready with unresolved points

Yes, that's what I'm talking about. Look at the GitHub history for this PR. Whatever you are doing is pushing tons of commits. Maybe you are rebasing and force pushing every time? That should be rare

ah ok, i followed this guide to catch up: https://developers.home-assistant.io/docs/development_catching_up/ can i keep up without force push somehow?

[allenporter]

You don't need to rebase and force push every time. You only need to do it when you're way behind "taking awhile to develop the feature" and certainly not every time you make a single commit.

(You just did it again..)

[cdce8p]

@xeniter Please don't request me for a review every time. I just added one comment which I thought might be helpful at the time. Unfortunately I don't have the bandwidth to do more at the moment.

[xeniter]

I think this is ready for merge if the updating of host based on zeroconf discovery is fixed. Please note that will require a config entry update listener which reloads the config entry when the host changes.

awesome, added update listener thanks for hint would have overseen it also for patience & detailed review didn't expect that many points

[allenporter]

Ready to merge once CI passes (approved run, will run now)

[xeniter]

@edenhaus https://github.com/home-assistant/core/pull/93750#discussion_r1464939398

what do you like as flow title exactly?

currently:

without flow_title set in strings.json:

[edenhaus]

@edenhaus #93750 (comment)

what do you like as flow title exactly?

currently:

without flow_title set in strings.json:

Sorry, I got confused with the config title vs. the flow title. It is fine