Dan Wallis

Results 98 issues of Dan Wallis

* Refactor test into individual tests, avoiding duplicate code. * Add test cases for no file & missing files to increase test coverage.

I've set the default to be off, but can trivially set this on by default by creating a `etc/config.xml` file with this set on if you would prefer.

### Description If an error occurs within this plugin, it will not change the availability of an email address and therefore should not change the result of calling `Magento\Customer\Model\AccountManagement::isEmailAvailable()` ###...

Fixes #407

partners-contribution
Progress: approved
Partner: Fisheye

I have recently opened a pull request on https://github.com/magento/magento2. When I ran the static analysis automated test, some complaints were raised (for unchanged parts of the files which were being...

partners-contribution
Progress: approved
Partner: Fisheye

I have noticed that this coding standard is using `PSR2.ControlStructures.ControlStructureSpacing` and `PSR12.ControlStructures.ControlStructureSpacing` is also available. From what I can tell, the latter includes checks from the former and some additional...

partners-contribution
Progress: approved
Partner: Fisheye

It makes sense to me that we should be automatically fixing problems which are able to be safely automated. Here's one case of this. I hope to be able to...

partners-contribution
Progress: approved
Partner: Fisheye

### Preconditions 1. In a template (`.phtml` file), make use of `$this->helper(SomeClass:class);`. For example, https://github.com/magento/magento2/blob/2.4.4/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml#L20 1. Magento Coding Standard version 25 ### Steps to reproduce 1. Run `phpcbf --standard=Magento2` on...

bug
Progress: PR created

Ref https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space Fixes #167

partners-contribution
Progress: approved
Partner: Fisheye

This is a small part of https://github.com/magento/magento-coding-standard/pull/347 as suggested in https://github.com/magento/magento-coding-standard/pull/347#issuecomment-999512251. https://eslint.org/docs/rules/comma-dangle Including a trailing comma when the closing `]` or `}` is on a different line means that it's...

partners-contribution
Progress: approved
Partner: Fisheye