magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

Include all Magento2 sniffs in Magento2Framework

Open fredden opened this issue 2 years ago • 0 comments

I have recently opened a pull request on https://github.com/magento/magento2. When I ran the static analysis automated test, some complaints were raised (for unchanged parts of the files which were being fixed/modified). To see these locally, I ran phpcs --standard=Magento2Framework path-to/file.php, however not all the complaints showed. When I ran phpcs --standard=Magento2 path-to/file.php the other complaints were visible. It doesn't seem right that the Magento2Framework standard doesn't include the rules defined in the Magento2 standard. This pull request fixes this inconsistency.

fredden avatar Jul 13 '22 10:07 fredden