magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon magento

Upgrade PSR2 -> PSR12 for ControlStructureSpacing

Open fredden opened this issue 1 year ago • 5 comments

I have noticed that this coding standard is using PSR2.ControlStructures.ControlStructureSpacing and PSR12.ControlStructures.ControlStructureSpacing is also available. From what I can tell, the latter includes checks from the former and some additional useful checks. This pull request changes to use the new version of this sniff.

Fixes https://github.com/YouweGit/coding-standard-magento2/issues/6 Related to: #128

fredden avatar Jul 12 '22 13:07 fredden

@sidolov what needs to happen to get this merged in? Is there anything I can do to help with that?

fredden avatar Feb 27 '23 21:02 fredden

@magento import PR to magento-commerce/magento-coding-standard repository

sinhaparul avatar Jun 05 '23 20:06 sinhaparul

@sinhaparul the Pull Request is successfully imported.

m2-github-services avatar Jun 05 '23 20:06 m2-github-services

So, what is blocking this PR?

Since PSR2.ControlStructures.ControlStructureSpacing.SpacingAfterOpenBrace conflicts with PSR12.ControlStructures.ControlStructureSpacing.FirstExpressionLine and PSR2 has been

Deprecated - As of 2019-08-10 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative. https://www.php-fig.org/psr/psr-2/

I'd love to advance it before 2024. 🤓

Morgy93 avatar Dec 09 '23 09:12 Morgy93

@sinhaparul @sidolov, is there any reason not to merge this?

ihor-sviziev avatar Dec 11 '23 06:12 ihor-sviziev