Results 844 comments of Francisco Giordano

The installer checks for presence of Fish directories to decide whether to create the setup config files. If Fish will be installed after Nix, the simplest solution is to `mkdir...

I don't think it is, I had to look at what the installer was doing. I think this could be improved.

I added source location in the error message in the latest version, but I haven't been able to test it because these errors are supposed to be unreachable. :slightly_smiling_face: Please...

A question to ask is whether each role should have its own constructor argument, or if we add just one argument and reuse it for all roles. A third option...

> in special cases, where we know they won't change, we could consider them as such If this is the intended rule there is no reason not to apply it...

FWIW I think it would be fine to entirely disallow reading `immutable` variables in `pure` context. In general, immutable variables are _not_ compile time constants, by design. The fact that...

What would be the semantics of `.exists()`?

I don't think that really mitigates the vulnerabilities that can arise from using `.isContract()`, because an account can pass the `EXTCODEHASH` test but still become a contract in the future....

See https://github.com/ethereum/EIPs/pull/8677#discussion_r1647794701. IMO this part makes no sense in the new design and should be removed: > In the case of multiple tuples for the same authority, set the code...