Francisco Giordano
Francisco Giordano
Yeah that should make the script at least catch this failure.
Hm, it seems like `ensure` should be doing that but it doesn't seem to be working as intended. https://github.com/foundry-rs/foundry/blob/b78509fb8e11b7f58a0021cd900b7c7a2d3be503/foundryup/foundryup#L239-L244
This issue seems to have been fixed by https://github.com/foundry-rs/foundry/pull/6155 which removed API requests from the script.
Is anyone actively championing this ERC? It would be great to get this onto the ERCs site if it is being actively developed. It is currently only here in this...
This should probably be merged. My understanding is it has been adopted and deployed by a number of protocols so it would be unfortunate to lose the spec in a...
> [...] and does not have dependency on the etherjs lib? Note that by using this library you already have a dependency on `@ethersproject/bytes` so I would do something like:...
>What's a good source of truth for these values? Answer: `SystemConfig.eip1559Elasticity()` and `SystemConfig.eip1559Denominator()` from https://github.com/ethereum-optimism/superchain-registry/blob/0831c2509152b457d865634616925ca6240b219e/superchain/configs/mainnet/base.toml#L60 I'm not sure what is the purpose of these parameters given that the true parameters...
This is unfortunately tripping into linting/CI errors from the EIP to ERC migration.
@yahgwai e5401cd needs to be reverted, the correct paths are `eip-` even though they are not the local filenames... (I know, it's confusing.)
@SamWilsn Following up on https://github.com/ethereum/ERCs/pull/1002#pullrequestreview-2871834594. I believe links are fixed now with the exception of ERC-7828 which was [previously](https://github.com/ethereum/ERCs/pull/1002#issuecomment-2878098440) [agreed](https://github.com/ethereum/ERCs/pull/1002#issuecomment-2881658681) to allow as an exception. We have two PRs that...