Results 844 comments of Francisco Giordano

Thanks for the issue. This cache is actually important because that's where the result of validations (i.e. safety checks) are stored. This is what ensures the safety of the deployment...

> at least when deploying the logic contract for the first time (i.e. when not upgrading anything) The issue here is that if you want safety checks in future upgrades,...

In theory it would work, but would be too difficult given the current architecture of the project. I'll take note as something that we'll probably need to solve in the...

Related to https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/647

External libraries can 100% modify state, they can even selfdestruct the contract.

If you're sure about that you can use an override via `unsafeAllow`.

Don't we need retyping in addition to renaming? To convert the Timer struct into an integer type.

@Amxx I changed one of the test cases you had written. There is already a built-in way to make that work, by using "retyped" on the state variable. I also...

Ok I see what's happening. If there is a retype annotation we explicitly skip the type comparison where the inside of the struct would get compared. We definitely make sure...

This check is different from the current checks because it makes an assertion about the history of a proxy. All current checks are purely assertions about a single contract's source...