Francisco Giordano
Francisco Giordano
We will be adding a beacon proxy like Dharma's in OpenZeppelin Contracts soon, so this is something we're interested in as well.
No updates on this yet. Some thoughts on how the implementation should proceed: We will need to parameterize `deployProxy` and `upgradeProxy` with a structure describing how to deploy and interact...
@spalladino What kind of logs do you mean? Since there is already logging around the proxy admin and implementation contract deployments.
Can you reproduce this consistently? If so, please share the reproduction steps.
The suggested code looks good to me. Can you open a PR?
Can you provide two sample contracts A and B that are marked as invalid when you try to upgrade from A to B?
The problem at the core here is that our definition of "valid" is not simply that an upgrade will not corrupt the storage _layout_, we also try to catch problems...
Here's a trick, you can use the ["retyped"](https://docs.openzeppelin.com/upgrades-plugins/1.x/faq#how-to-rename) feature for layout-compatible types. In the case of enums, if you're getting an error from the following variable: ``` contract C {...
This is currently not a priority as the only thing it will give us is more sophisticated checks, in the sense that we are currently disallowing some things which would...
This is an interesting idea. You should be able to implement it in solidity-docgen 0.6 with a custom template that renders conditionally if `item.documentation` is defined.