Fabian Meumertzheim

Results 1670 comments of Fabian Meumertzheim

Just keep in mind that Bzlmod and even more so the rules_go module are still experimental. If you find bugs, I will happily fix them though.

@tingilee `args` is a magic attribute, its value currently can't be propagated to targets depending on a test. This needs to be fixed in Bazel first, see https://github.com/bazelbuild/bazel/issues/16076.

@tingilee Can you use a fork of rules_go or patch this PR in for now? After Bazel 6 has been released, we can probably raise our minimum version of Bazel...

The workaround should no longer be required with Bazel 6, which will have https://github.com/bazelbuild/bazel/commit/7694cf75e6366b92e3905c2ad60234cda57627ee.

Those are just cherry-picks of commits by the real expert for this domain, @sdtwigg. But I will try to summarize what I know. Currently, the hash is computed in [FunctionTransitionUtil](https://github.com/bazelbuild/bazel/blob/b63a19dd6cad6b0a1dda2ffa381bf4c553054190/src/main/java/com/google/devtools/build/lib/analysis/starlark/FunctionTransitionUtil.java#L422)....

I would welcome any PR that adds this feature and can offer guidance to anyone who wants to pick this up.

Do you have a reproducer I can run on my Mac? The output with `--toolchain_resolution_debug=@bazel_tools//tools/cpp:toolchain_type` would be helpful. Also, which architecture/OS has your image? The correct future solution for these...

This could be achieved relatively easily by adding a `config_value` for `host_sdk` (or `host`, to avoid duplicating `sdk`) [here](https://github.com/bazelbuild/rules_go/blob/4d4a2454c588dab27853ccffb03fcb9205001192/go/private/BUILD.sdk.bazel#L100) conditionally if the [_sdk_build_file](https://github.com/bazelbuild/rules_go/blob/4d4a2454c588dab27853ccffb03fcb9205001192/go/private/sdk.bzl#L234) function is called from [_go_host_sdk_impl](https://github.com/bazelbuild/rules_go/blob/4d4a2454c588dab27853ccffb03fcb9205001192/go/private/sdk.bzl#L30). @ash2k or...

@tetromino I just submitted a PR that should add support for `go_proto_library` to rules_go with Bzlmod: https://github.com/bazelbuild/rules_go/pull/3283. I manually verified that it can build buildozer.

rules_go 0.34.0 is now available in the register and should support `go_proto_library`.