Fabian Meumertzheim

Results 1662 comments of Fabian Meumertzheim

> We've had some discussions about symlinks internally, and there are many more corner cases than I realized. I've started putting together the information we have, so we can avoid...

@oquenchil I noticed that the starlark implementation has already been fixed. This PR still adds a test and a fix for the Java implementation. Is that useful?

@gregestren Another edge case that wouldn't arise if `allow_multiple` flags used `attr.string_list`. Do you think that alternatives such as https://github.com/bazelbuild/bazel/pull/14911 could be considered in time for Bazel 6? I'm a...

I think it would. I'm back on June 30, feel free to send an invite.

> Is https://github.com/bazelbuild/bazel/issues/15653#issuecomment-1152598263 still active even with this PR? Yes, I don't expect the current PR to fix that bug.

> Where were we at with this PR, in the context of the wider discussion we all had last month? It's another reason for getting rid of `allow_multiple`, but is...

@gregestren https://github.com/bazelbuild/bazel/commit/2f7d965287ddfa056b169cf16144d05f78d03c7d caused a large conflict. CI will tell whether I found the right new place for the updated logic.

@aranguyen Could you review this PR? It has been stuck for a while, maybe we can move it forward.

@aranguyen Friendly ping, would be great to get this into Bazel 6.

The principled solution for this mess is [Bzlmod](https://bazel.build/build/bzlmod). Given how stretched everyone is and how brittle `WORKSPACE` semantics are, I'm not sure whether we can substantially improve this situation. Incremental...