Fabian Meumertzheim

Results 1673 comments of Fabian Meumertzheim

Bzlmod tests fail with ``` ERROR: While parsing option --startup_time=18446744073709550929: '18446744073709550929' is not a long ``` even on retries. Maybe something is off with the clock on that executor?

> ignoring errors returned by `binary.Write` We are writing to a `hash.Hash`, which can never fail.

Would it be possible to rewrite these scripts so that they only require `/bin/sh`? Some of them are only relevant for development and could just use `/usr/bin/env bash`.

We can add them, but it won't help much as WORKSPACE has the first definition win. As a result, WORKSPACE users usually have to manually define the repos at the...

The standard way would be to add `dev_dependency = True` to the `use_extension` call. Does that work in your case?

Then the question is why the LLVM toolchain is not a dev dependency of `bazel_rules_nvc`. Does that ruleset have to reference any LLVM binaries explicitly?

It does count, but using llvm_toolchains via a module extension for that purpose is pretty brittle (whence the check): The end user may register a different LLVM version, they may...

> In turn, in bazel_rules_nvc, I use toolchains_llvm to ensure that nvc is compiled with a hermetic toolchain. Could you make this more precise? What kind of BUILD API do...

> Maybe my understanding here is too simplistic, but my expectation was: "I compile a thing from source with this specific compiler; I then use the thing. Build system doesn't...

@EdSchouten What do you think of introducing an `@rules_go//go` style alias for `clang-format`? A problem with the current approach I only now realized is that such an extension usage would...