Fabian Meumertzheim comments

Results 1673 comments of


                                            Fabian Meumertzheim

[FR/Proposal] Support use of multiple SDK versions in the same bazel workspace

@kmicklas Thanks! Let me know in case you get stuck, happy to provide guidance.

remove dependency on go-genproto

That sounds correct. We may have to add the repository under both the old and the new name for the transitionary period.

building with race detection (`@io_bazel_rules_go//go/config:race`) is very slow especially if using Go binaries to generate code

`race = "off"` not having an effect sounds like a bug in itself. Overall, however, I think that this FR is better served by a different mechanism: We could introduce...

Add support for --@io_bazel_rules_go//go/toolchain:sdk_version flag.

@JamesMBartlett If you rebase on `master`, you should be able to resolve the CI failure by updating the patch in `tests/bcr/bcr.patch` - if you have trouble doing that, let me...

Runfiles should be relative to runfiles root, not workspace subdirectories

@sluongng That would be highly appreciated. Just keep in mind that there is https://github.com/bazelbuild/bazel/issues/15029, meaning that all runfiles libraries will potentially have to undergo fundamental changes before Bazel 6. For...

go_proto_library: default "compiler" misinterprets importpath value with semicolon package name suffix

I think it's actually very close - it is supposed to land in 5.3.0: https://github.com/bazelbuild/bazel/pull/15854#issuecomment-1184618892 I will definitely take a deeper look when it has been released and see whether...

nogo: exclude_files should accept anchored regexps

This sounds strange. Are the paths perhaps going through https://github.com/bazelbuild/rules_go/blob/31d17212968b472032035a45353a1751f1c0f529/go/tools/builders/env.go#L342?

Add `go_cross` rule for cross-compilation.

@achew22 This generally looks good to me. Are you also fine with the new API?

Add `go_cross` rule for cross-compilation.

Thanks again for the great contribution, @JamesMBartlett!

README: Fix sha256 of io_bazel_rules_go

Look like the gazelle section didn't get updated to v0.34.0. Could you do that in this PR?