Fabian Meumertzheim
Fabian Meumertzheim
@jsharpe I would be totally fine with you adding `target_compatible_with` to skip the new targets on Windows.
The short answer is yes, we absolutely want this, but the proper way to achieve that would probably be by porting toolchains_llvm over to the new rules-based C++ toolchain approach....
That's true and I don't want to let perfect be the enemy of good here. If we find a way to make this possible that has a clear migration path,...
This should live in rules_go's `go_sdk` extension, not in gazelle's `go_deps`. Gazelle's go env specifically doesn't influence the build time environment and it's not a good fit for what is...
Yes, Gazelle has to be changed to ignore these lines. Your plan sounds good!
Checking for strings that start with `@@` and contain `//` seems pretty decent. Canonical repo name shorthands are probably no longer relevant with Bzlmod since it's very unlikely that a...
Does this actually fix a bug? Could you provide more details on why this helps?
Generally happy to merge this, but I don't see how this case can arise. Could you share more details on the situation in which you see this crash?
The only source for repoPath in this code block is https://github.com/bazel-contrib/bazel-gazelle/blob/ffa4e789475efb24104bcc270fae91cd97e08747/internal/go_repository.bzl#L344 and I don't see how that could return `"."`. If we merge this, it might mask a bug somewhere...
Not sure whether the logic for cgo include paths would be correct in that case though. This will avoid the crash, but from the perspective of this repo, a crash...