Fabian Meumertzheim comments

Results 1684 comments of


                                            Fabian Meumertzheim

Test path mapping with ThinLTO

Yeah, not yet. My plan was for this test to reproduce just that and then fix it.

misleading error message for missing `protos` attribute on go_proto_library

At HEAD the error message has been improved: https://github.com/bazel-contrib/rules_go/blob/55932be4203d0f14f79231a143cfaec0836d53d4/proto/def.bzl#L74 Do you think that's good enough?

misleading error message for missing `protos` attribute on go_proto_library

Would you be interested in sending a PR? We have access to the rule kind at that point, wonder could make the error message more precise for `proto_library`.

Bazel build: No repository visible as '@rules_go'

Could you try adding an override with `build_file_generation = "clean"` (example: https://github.com/bazel-contrib/bazel-gazelle/blob/b13c1573c378bb3dd9b9de1397db89d0392f8e72/tests/bcr/go_mod/MODULE.bazel#L162)?

Bazel build: No repository visible as '@rules_go'

If you have the time, could you add this module to https://github.com/bazel-contrib/bazel-gazelle/blob/b13c1573c378bb3dd9b9de1397db89d0392f8e72/internal/bzlmod/default_gazelle_overrides.bzl#L17 with mode `clean`?

[email protected]

Please resolve the conflict

Declare test toolchain requirements on the `test` exec group

@gregestren Could you review this?

Declare test toolchain requirements on the `test` exec group

@tetromino @gregestren Friendly ping

Package's ".x" is not reproducible between dependency upgrade

@joeljeske Does this reproduce if you make the implementation more complicated? I wouldn't be surprised if the export data ensures that this function is inlined into every caller.

Package's ".x" is not reproducible between dependency upgrade

@annapst Could you file an issue with upstream for this? That's a pretty clean diff and the existing explanations for why there may be a difference don't apply.