Fabian Meumertzheim

Results 1654 comments of Fabian Meumertzheim

> The module extension is marked reproducible That just means that it is tracked in the persistent lockfile, not the one in the workspace. The repo rule itself would need...

I can't reproduce this with: ``` bazel_dep(name = "rules_go", version = "0.55.1") bazel_dep(name = "gazelle", version = "0.44.0") go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps") go_deps.from_file(go_mod = "//:go.mod") ``` When I run: ```...

This is expected, we are moving away from explicitly named SDK repos in favor of toolchain resolution and Bzlmod was a convenient opportunity for that. Can you use `go fmt`...

@jmhodges Would you be willing to add this target along the lines of `@rules_go//go`?

Thanks for the report, that's a valid case for dropping `pure` and `static` from `go_tool_transition` (but not from the other transitions). Would you be willing to send a PR?

@moribellamy No correctness gotchas, but you may end building tools such as protobuf multiple times.

I like where this is going, but CI is red

This PR needs a rules_cc release with https://github.com/bazelbuild/rules_cc/commit/53b92d1bc57a5af745ef8968fba505a2210cd227

As far as I can tell LTO by itself doesn't, but this test compiles generated files and thus needs the special feature.