Fabian Meumertzheim

I can understand that this is somewhat unexpected, but Gazelle needs to be in the same dep tree so that you can safely build language plugins for it. We try...

> After changing the minimal reproducer to make fsnotify an indirect dependency, confirmed that `go_deps.config(check_direct_dependencies = "error")` no longer causes it to fail. I think that's a bug? The check...

`gazelle:proto disable` not propagating to external deps is intentional, directives generally only apply to the subtree of the directory they appear in. See https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/bzlmod.md#gazelle-directives for how to add directives to...

Making this attribute a string means that we might not convert labels correctly (i.e. in the context of the rules_go module, not the module containing the `go_binary` target). Could we...

@mattyclarkson I don't have write access, I can just help you get this in your shape for review by Google folks

> With this issue, any changes to `NAME` in the client environment won't propagate until the server restarts. Could you split the fix into a separate PR? That would make...

Thanks for compiling this list, I'll have to think about this more. Since some repo rules do depend on the environment quite heavily, have you considered making this behavior configurable...

> unless overridden or explicitly removed via --repo_env=-VARNAME The syntax for that is `--repo_env==VARNAME`

I also like the idea of maintaining the two lists of "top-level" and "per-platform" flag values and keeping the former while switching out the latter.

CC @joeleba Based on https://github.com/aspect-build/rules_js/issues/1412#issuecomment-2012217182 and the error message it looks more likely that this has something to do with `IncrementalPackageRoots` and not so much with remote execution. Do you...