Fabian Meumertzheim comments

Results 1662 comments of


                                            Fabian Meumertzheim

Add `bazel mod show_repo --output=streamed_proto` and `--output=streamed_jsonproto`

Yes to proto output, but I'm not sure whether @Wyverald would like to further codify the reuse of build rule concepts for repo rules.

Add `bazel mod show_repo --output=streamed_proto` and `--output=streamed_jsonproto`

@bazel-io fork 9.0.0

Using the repo name rules_go removes proto embed from all go_library rules

Could you send a PR that adds a reproducer for this to some subdirectory of https://github.com/bazelbuild/bazel-gazelle/tree/master/tests/bcr/go_mod/proto, which uses a non-`io_bazel_rules_go` repo name? Then I could work on a fix. I...

Using the repo name rules_go removes proto embed from all go_library rules

I can look into it, but I'm currently preoccupied with the Bazel 8 release.

Gazelle cannot parse new go.mod directives

The `go_deps` extension with Bzlmod has support for this directive already. Is it possible for you to migrate? Happy to review a PR as well.

Gazelle cannot parse new go.mod directives

Do they straight up don't work with Bzlmod? You should generally be able to keep them in WORKSPACE or WORKSPACE.bzlmod and just migrate the rest.

Gazelle cannot parse new go.mod directives

I unfortunately don't know, I don't use them myself.

GoPackagesDriver - tree artifacts support

Sorry, I forgot about this for a long time. @lromor Could you resolve the merge conflicts? @JamyDev Did you get to test this?

GoPackagesDriver - tree artifacts support

@jayconrod This looks good to me, but the packagesdriver is definitely a weak spot of mine. Could you review this as well?

server: Enforce CSP with `--app.strict_csp_enabled`

Well, that's another way to discover all product features. I'll take a look and include a fix for this violation.