bazel-skylib icon indicating copy to clipboard operation
bazel-skylib copied to clipboard

Add `structs.merge`

Open mattyclarkson opened this issue 6 months ago • 4 comments

one = struct(a = 1)
two = struct(b = 2)
overwrite = struct(a = 3)
merged = structs.merge(one, two , overwrite)
# struct(a = 3, b = 2)

mattyclarkson avatar Jun 13 '25 09:06 mattyclarkson

I am unclear why this is failing the buildifier job in the CI.

buildifier (same version as CI) is clean for me locally on lib/structs.bzl, tests/structs_test.bzl, MODULE.bazel and WORKSPACE which have been modified.

Maybe an infra-failure?

mattyclarkson avatar Jun 20 '25 12:06 mattyclarkson

I learnt how to read the BuildKite annotations tab 😊 buildifier should be fixed.

mattyclarkson avatar Aug 20 '25 14:08 mattyclarkson

@fmeum this is good to go.

mattyclarkson avatar Aug 20 '25 15:08 mattyclarkson

@mattyclarkson I don't have write access, I can just help you get this in your shape for review by Google folks

fmeum avatar Aug 20 '25 15:08 fmeum