Fabian Meumertzheim

Results 1688 comments of Fabian Meumertzheim

As the flag isn't available in older Bazel versions (which we still test against), we need to set it on individual CI runs instead.

[email protected] contains a fix. @ouillie Can you use `patch_cmds` instead? That's the recommended way to run arbitrary commands.

There also won't be a new CAS entry, so this would virtually be all upside. RBE does support source directories now. That said, ideally `allow_symlink` would just be the default...

@ulfjack I think that's not true, `allow_symlink` defaults to `False` in the `copy_file` macro and `is_windows` is only used to decide whether to use a shell script or a bat...

Would you be interested in sending a PR?

They are handled separately, but they would be available in `GotOptionsEvent`, where they could be added to the unstructured BES list of options. I will send a PR to Bazel.

@tpudlik Solving this properly requires quite a bit more effort than I expected. Could you file an issue on the Bazel repo first?

@kotlaja @comius I tried to enable `--incompatible_auto_exec_groups` in rules_go, but found it to be incompatible with `--incompatible_enable_proto_toolchain_resolution`. The root cause is that https://github.com/protocolbuffers/protobuf/blob/6690ab42d855ea19d9a24cd99b0375910ea772ca/bazel/private/toolchain_helpers.bzl#L48 and https://github.com/bazelbuild/rules_proto/blob/db09d58959ed951db34c2e056cef084954e55640/proto/private/rules/proto_toolchain_rule.bzl#L23 (depending on where the proto...