Fabian Meumertzheim

Results 1688 comments of Fabian Meumertzheim

Instead of retrying on a timeout, would a longer timeout work for you? I don't know whether it's configurable yet, but allowing it to be increased seems more natural to...

You can use https://github.com/bazel-contrib/bazel_features to conditionally remove the `exec` transition only in those versions of Bazel that include the change.

Sorry for the confusion I caused with the statement quoted above, I think I misunderstood (and thus misrepresented) Lin's plans. The special situation with rules_go is that we (have to)...

@sywhang Friendly ping, is this something you would accept contributions for in case all of you are busy?

That's a very reasonable suggestion (thanks for providing all the context!). The gRPC remote downloader is effectively ownerless right now, but I can pre-review a PR.

rules_go only depends on rules_proto if you use proto functionality, which is why it was decided at some point to not provide this dep implicitly. You may have to update...

Adding it to the macro doesn't really help that much as the WORKSPACE setup for rules_proto requires the user to call three dep macros, which we can't do for them:...

> I am not sure about this one, but I am leaning towards "yes". If the last line already ends with a newline, and "final_newline" is true, then it is...

I sent https://github.com/bazelbuild/buildtools/pull/1373 to make it easier to implement this feature. Let's wait for that to land as well as a release, then our job here will become much easier....