Fabian Meumertzheim
Fabian Meumertzheim
It should and if it doesn't, we should fix that.
Looks like I just forgot to do this after https://github.com/bazel-contrib/bazel-gazelle/commit/f590ca1488eff5063a9549a3edba8266a6ce6134. Would you be willing to send a PR that prepends the constant here: https://github.com/bazel-contrib/bazel-gazelle/blob/dc5cce4501e56d13a5383d860970caa0f42421d7/def.bzl#L144?
Just a note: Even if we implement this, we still wouldn't benefit from the repository cache in its current form as we can't provide a hash for the `.zip` file...
See https://github.com/bazel-contrib/rules_go/issues/3513, rules_go still uses the legacy mechanism for coverage which doesn't support this use case. Contributions welcome :-)
I can't reproduce this on Linux with these file contents: ```starlark # MODULE.bazel bazel_dep(name = "rules_go", version = "0.49.0") bazel_dep(name = "gazelle", version = "0.38.0") go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk") go_sdk.download(version...
Happy to merge the PR, but the breakage is unexpected and certainly not intended for Bazel 8. Are you perhaps using gazelle from a repo that happens to provide auto...
Could you check whether this repros from other repos (not called "rules_android") too?
I tried to reproduce this in a project that isn't special-cased by Bazel, but failed to do so. Could you share a reproducer? I certainly agree that we should migrate...
I'm working on a release that will fix this, but there are some unrelated issues that make this a bit more difficult.
@tjgq https://github.com/aspect-build/rules_js/tree/main/js/private/test/image/non_ascii If this is valid UTF-8 we should be able to get this to work without a rollback.