bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

rules_* modules broken with Bazel 8.0.0rc8

Open meteorcloudy opened this issue 1 year ago • 17 comments

The following modules are broken with [email protected] (Updated Dec 9):

BCR Bazel Compatibility Test: https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/103

[email protected]

Maintainers: @ted-xie, @ahumesky

[email protected]

Maintainers: @bazelbuild/bcr-maintainers

[email protected]

Maintainers: @lalten

[email protected]

Maintainers: @keith

[email protected]

Maintainers: @srikrsna-buf

[email protected]

Maintainers: @matts1

[email protected]

Maintainers: @kczulko

[email protected]

Maintainers: @pjk25

[email protected]

Maintainers: @sgammon

[email protected]

Maintainers: @avdv, @aherrmann

[email protected]

Maintainers: @luispadron

[email protected]

Maintainers: @EdSchouten

[email protected]

Maintainers: @Bencodes, @restingbull, @nkoroste

[email protected]

Maintainers: @benradf, @aherrmann

[email protected]

Maintainers: @alexeagle, @thesayyn

[email protected]

Maintainers: @opicaud

[email protected]

Maintainers: @oxidase

[email protected]

Maintainers: @aaliddell

[email protected]

Maintainers: @jvolkman

[email protected]

Maintainers: @avdv, @aherrmann

[email protected]

Maintainers: @jmmv

[email protected]

Maintainers: @cgrindel

[email protected]

Maintainers: @chickenandpork

[email protected]

Maintainers: @aherrmann

meteorcloudy avatar Nov 26 '24 10:11 meteorcloudy

FYI: rules_contest has been fixed - the failure was due to the flag flip of --incompatible_disallow_empty_glob.

nya3jp avatar Nov 26 '24 12:11 nya3jp

rules_ruby are fixed in 0.14.1, the issue was usage of --incompatible_remote_results_ignore_disk in tests.

p0deje avatar Nov 26 '24 20:11 p0deje

rules_wasm fixed: https://github.com/bazelbuild/bazel-central-registry/pull/3268.

Filed https://github.com/bazelbuild/bazel/issues/24499 to discuss a better solution, but was able to just duplicate some data as a workaround. The breaking change stems from https://github.com/bazelbuild/bazel/commit/27487cf11f61eb23108f8df129dc1a00ee1a4370 which causes the patch tool for http_archive to always receive a -p option, even when patch_args is empty. Is that an issue for anybody else? Or was that just because of my abuse of patch_tool.

ouillie avatar Nov 26 '24 22:11 ouillie

[email protected] contains a fix.

@ouillie Can you use patch_cmds instead? That's the recommended way to run arbitrary commands.

fmeum avatar Nov 27 '24 11:11 fmeum

[email protected]

Maintainers: @EdSchouten

It looks like all of these breakages are caused by jsonnet, not rules_jsonnet. Unfortunately, I am not able to make able to make contributions to that repository directly. Sorry!

Once these build failures are addressed on the jsonnet side, I'd be more than happy to cut a new release of rules_jsonnet that depends on it.

EdSchouten avatar Nov 28 '24 09:11 EdSchouten

@EdSchouten Yes, jsonnet is also identified in https://github.com/bazelbuild/bazel-central-registry/issues/3056 @mortenmj Can you help fixing this since you contributed the initial BCR module.

meteorcloudy avatar Nov 28 '24 09:11 meteorcloudy

rules_sh, rules_nixpkgs and rules_haskell all fail with the same error:

	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/2bbac50a5364a2d14c5e3065383ed7e2/external/rules_sh+/sh/posix.bzl", line 11, column 55, in <toplevel>
		load("@bazel_tools//tools/cpp:lib_cc_configure.bzl", "get_cpu_value")
Error: file '@bazel_tools//tools/cpp:lib_cc_configure.bzl' does not contain symbol 'get_cpu_value'

We were relying on this macro, but apparently it has been removed and the one in rules_cc is private. We are going to vendor a copy of this macro into our rules to solve this, but maybe others are also having this issue and copying this code around seems not very maintainable. WDYT?

avdv avatar Nov 28 '24 10:11 avdv

@avdv I think we could expose this in https://github.com/bazelbuild/rules_cc/blob/8395ec0172270f3bf92cd7b06c9b5b3f1f679e88/cc/toolchains/toolchain_config_utils.bzl#L22

Sent https://github.com/bazelbuild/rules_cc/pull/283

meteorcloudy avatar Nov 28 '24 10:11 meteorcloudy

rules_flex fix: https://github.com/bazelbuild/bazel-central-registry/pull/3285

jmillikin avatar Nov 28 '24 13:11 jmillikin

rules_Synology will take a few days to fix: I butchered the bcr template and I’m afk 3 days. I can’t reproduce the failure but have a fix for a guess of the cause into v0.0.3

chickenandpork avatar Nov 28 '24 17:11 chickenandpork

rules_Synology will take a few days to fix: I butchered the bcr template and I’m afk 3 days. I can’t reproduce the failure but have a fix for a guess of the cause into v0.0.3

After some templating issues, #3330 brings in v0.1.1 (via chickenandpork/rules_synology#176) which might have a fix for rules_synology -- unfortunately, I cannot repro, so I'm guessing based on the error message.

update 2025-02-21

  • #3430 merged rules_synology-0.2.0
  • #3859 offers rules_synology-0.2.2

chickenandpork avatar Dec 05 '24 23:12 chickenandpork

@meteorcloudy can we pass --check_direct_dependencies=off in this CI job? in my case it's a bcr module where that as an error is checked in to the .bazelrc, so it's a false positive https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367c7-9404-453f-9c57-66b13aca10d9

keith avatar Dec 05 '24 23:12 keith

@keith --check_direct_dependencies is now set to warning when the Bazel version is changed, the new error from rules_apple_linker suggests rules_apple might need to be updated.

meteorcloudy avatar Dec 09 '24 08:12 meteorcloudy

@meteorcloudy what would be a procedure to remove [email protected] from this check? I don't plan to add support for Bazel >=8 to the package

oxidase avatar Dec 26 '24 08:12 oxidase

@oxidase You can simplify ignore this notification for now? Those kind of issues won't be filed too frequently.

meteorcloudy avatar Jan 02 '25 11:01 meteorcloudy

These issues for rules_android should be fixed now with the v0.6.0 release.

ted-xie avatar Jan 02 '25 16:01 ted-xie

rules_elm should be fixed starting from v1.1.0

kczulko avatar Feb 03 '25 18:02 kczulko