Francois Marier
Francois Marier
Question about the video: it looks like there's still a long delay after the connection status turns green. Is that the usual delay on your network (e.g. because you're going...
Noting that https://github.com/brave/brave-browser/wiki/Custom-Headers#x-brave-ads-enabled-header will need to be updated after this PR is merged.
Does it continue to fall back to https://location.brave.com if it fails to get a location using GeoClue2 for any reason?
> now we should fallback to our default location services if GeoClue isn't available Is the fallback service used in all of these cases? - `LinuxGeoClueLocationBackend` is false - geoclue2...
> This is comparable to what Chromium does on Windows/Mac Ok, that sounds good then. No need to make it more robust than Windows/Mac.
I can't reproduce on `1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (64-bit) `.
Indeed, we'd have to add a patch for https://source.chromium.org/chromium/chromium/src/+/main:chrome/installer/linux/common/desktop.template;l=172;drc=a3ab59c808b58d126b6ca5fd588516c203ffa436 in our [existing patch](https://github.com/brave/brave-core/blob/b0827816c23c815ad6b7be6a67b17ad9f946e834/patches/chrome-installer-linux-common-desktop.template.patch).
The other thing that this suggests is that we are likely not running these URLs through our privacy filters (e.g. debouncer, query string filter).
To confirm, I updated the test page to add an `fbclid` parameter to the URL and it doesn't get stripped out: 
I think this should be a News-specific fix (for these custom RSS feeds). We should not change any other internal requests.