Francois Marier

@LaurenWags It should be fine on just one desktop platform. There's nothing OS-specific about this.

Follow-up issue for the tor log on Windows: https://github.com/brave/brave-browser/issues/39467

> I am also experiencing this issue with Brave. Despite having configured the settings to clear browsing history and data on exit, my tabs reappear every time I restart the...

@Bob563-sudo Just to make sure I understand correctly: when you set the option to "Open the New Tab page", your tabs are gone, but you still see a session folder...

I think it's fine to skip the check when users explicitly state that they want to send the input to a search engine (by using `:g` or `:br` for example).

> Is `IsQueryPotentiallyPrivate()` sufficient for our criteria for making search suggestion default on? I reviewed the set of [security requirements](https://github.com/brave/reviews/issues/1567#issuecomment-2093556873) that were agreed to and it looks like `IsQueryPotentiallyPrivate()` is...

I have talked to Yan and she agreed that we should have parity with Search in terms of excluding private queries before rolling this out.

This might be due to the password store (which is also used to encrypt cookies) not being detected properly on your machine: https://support.brave.com/hc/en-us/articles/29808985123085-Sensitive-data-storage Try specifying it manually on the command-line...

> Thats also happen on barve mobile for android sometimes! Do you have Brave Sync enabled?

> it is using kwalletmanager5 in my desktop environment Which desktop environment? Does it work fine if you start the browser with [`--password-store=kwallet5`](https://source.chromium.org/chromium/chromium/src/+/refs/tags/128.0.6613.85:docs/linux/password_storage.md)?