brave-core
brave-core copied to clipboard
Show Tor daemon status when using the purple Tor button.
Resolves https://github.com/brave/brave-browser/issues/37927
https://github.com/brave/brave-core/assets/73575789/11d2fe0f-907c-43a4-9934-8d78aa647d76
Submitter Checklist:
- [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
- [x] There is a ticket for my issue
- [x] Used Github auto-closing keywords in the PR description above
- [ ] Wrote a good PR/commit description
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issue - [ ] Checked the PR locally:
- [ ] Ran
git rebase master
(if needed)
Reviewer Checklist:
- [x] A security review is not needed, or a link to one is included in the PR description
- [x] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [x] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in
gn
- [ ] Code follows the style guide
- [x] Test plan is specified in PR before merging
After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
Test Plan:
- In a normal window, open https://brave.com/
- Click the purple Tor button in the URL bar.
- This opens a new private window with Tor and attemps to load https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/index.html.
- Confirm that you see the Tor is connecting notification in the top left corner. Eventually it turns to Tor connected successfully in green.
Question about the video: it looks like there's still a long delay after the connection status turns green. Is that the usual delay on your network (e.g. because you're going through bridges or something like that)?
Question about the video: it looks like there's still a long delay after the connection status turns green. Is that the usual delay on your network (e.g. because you're going through bridges or something like that)?
I always have tor running at this speed. I can only use bridges, direct connection is prohibited.