Francois Marier
Francois Marier
If you want to try this out, you can start Brave with `brave-browser --js-flags=--jitless` and that will disable the JIT entirely. One problem I ran into is that this disables...
Are you able to reproduce if you upgrade to `1.70.126` again on your machine and then revert back to `1.70.123` afterwards? In other words, is it consistently throwing away your...
Removing old packages (maybe keeping the last X ones) makes sense to me. I don't know why we keep everything forever.
https://github.com/brave/adblock-lists/pull/1858 was a failed attempt at debouncing this using the existing base64 decoder.
Yes, the security alert was a false positive. This is ready for a code review from the appropriate codeowners.
I noted that: - `components/web_discovery/browser/document_extractor/rs/BUILD.gn` has `allow_unsafe = true`, - `components/web_discovery/browser/document_extractor/rs/src/lib.rs` has `#[allow(unsafe_op_in_unsafe_fn)]`. I didn't see any `unsafe` blocks while going over this. Do we have any unsafe code or...
> @fmarier , do we need to submit the request for security review for this PR? If you can file one and assign it to me, I'll take care of...
> I updated https://github.com/brave/brave-browser/wiki/Brave-Ads-Endpoint:-non-Brave-Rewards-users Is `https://github.com/brave/brave-core/blob/issues/38955/components/brave_ads/core/internal/account/confirmations/non_reward/README.md` a stable link? It won't be the latest, that's for sure since it's pointing to an issue.
I'm not familiar enough with the code to be able to guide you, but it does sound like a reasonable feature to add behind an envvar.
I have opened an issue upstream: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42688