Luke Pacholski
Luke Pacholski
Hey @brianhall—do you think you will have a chance to make change I requested in this PR? Let me know. If not, we can take over and finish the work...
No worries @brianhall—thanks for the update!
Hey @rkgupta21 - are you still working on this PR? It doesn't look like ``project.publish_url`` is available in the template that renders the publish popup. It also looks like the...
I like your solution @humphd - makes sense. If you can just slap an ``.offline`` class around the userbar, we can do the rest with CSS. I'm assuming that the...
Fixing #2479: Allow user to change the project description without needing to publish their project.
OK - thanks for submitting this PR @jmrodriguesgoncalves! My suggestion for this is to save the description when someone clicks outside of the Publish dialog and the dialog closes it....
Fixing #2479: Allow user to change the project description without needing to publish their project.
Yeah the `Cancel` case is a bit strange for us. I just thought of a great solution however... What if we just remove the `Cancel` button from the UI altogether?...
Fixing #2479: Allow user to change the project description without needing to publish their project.
Hey @jmrodriguesgoncalves - yeah let's def go ahead with removing the `Cancel` button then. I'll dig into the code and look for the click-underlay stuff
Fixing #2479: Allow user to change the project description without needing to publish their project.
OK @jmrodriguesgoncalves - I think I found what we need. Check out [this line here](https://github.com/mozilla/thimble.mozilla.org/blob/master/public/editor/scripts/ui/index.js#L437). That's where `hidePublishDialog()` is defined, which is then passed into the `new Underlay` constructor on...
Fixing #2479: Allow user to change the project description without needing to publish their project.
Yeah do what you need, you can just keep updating this PR, we can squash it all into one commit when we merge it.
Fixing #2479: Allow user to change the project description without needing to publish their project.
Hey awesome @jmrodriguesgoncalves - I'll test out the functionality now, and let's ping @gideonthomas so he can provide his thoughts on the back-end piece you asked about. _Edit: OK—I confirmed...