thimble.mozilla.org icon indicating copy to clipboard operation
thimble.mozilla.org copied to clipboard

Add 'My Projects' link in the header for logged-in users - Issue 2533

Open brianhall opened this issue 8 years ago • 6 comments

Closes: #2533

This PR adds a "My Projects" link to the header for a logged-in user, allowing quick access to their projects.

Feedback welcome!

brianhall avatar Oct 24 '17 02:10 brianhall

@brianhall, this works great! Thanks for the patch. I'm going to hold of on approval until I clarify the text that should show up. @flukeout, should the text be "My Projects" or should it be the same as what we have in the user dropdown menu - "Your Projects"?

gideonthomas avatar Nov 03 '17 18:11 gideonthomas

Reviewing now!

flukeout avatar Nov 13 '17 22:11 flukeout

Hey this is really great. I'd recommend putting the Your Projects link next to the User dropdown, like this, however...

image

My reasoning is that that's where the user is acting and seeing changes, so they are more likely to notice it. Mixing it into the main site navigation makes it harder to notice and connect mentally to the User's account stuff, which is all in the top right. We can adjust spacing around the items it if feels like we've got too much stuff in the top bar.

Thanks for getting this change started @brianhall. I think it will be very useful 👍

flukeout avatar Nov 13 '17 23:11 flukeout

Hey @brianhall—do you think you will have a chance to make change I requested in this PR? Let me know. If not, we can take over and finish the work as well. Cheers!

flukeout avatar Dec 01 '17 22:12 flukeout

Hi @flukeout! No problem, I'd like to get it fixed up. May take another day or two, but I'll submit the requested changes. 👍

brianhall avatar Dec 04 '17 14:12 brianhall

No worries @brianhall—thanks for the update!

flukeout avatar Dec 04 '17 17:12 flukeout