thimble.mozilla.org icon indicating copy to clipboard operation
thimble.mozilla.org copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

[WIP] Fixes #1918, Change Publish popup title when project is Live

Open rkgupta21 opened this issue 7 years ago • 2 comments

Fixes #1918
Added variable to the messages.properties file and added conditions to publish.html

However, I believe that i am not able to access project.publish_url in publish.html. It always goes to else statement.

rkgupta21 avatar Apr 21 '17 20:04 rkgupta21

Hey @rkgupta21 - are you still working on this PR? It doesn't look like project.publish_url is available in the template that renders the publish popup. It also looks like the URL for the published project is added in the publisher.js file - so I think that might be a better place to show / hide the appropriate heading.

You could maybe add a class to the popup depending on what state it is in, then show / hide the appropriate elements.

flukeout avatar Sep 11 '17 19:09 flukeout

Hi @flukeout,

You are totally right. I have just submitted another pull request for this fix. Please review

https://github.com/mozilla/thimble.mozilla.org/pull/2482

IamHDT avatar Sep 12 '17 15:09 IamHDT