hive icon indicating copy to clipboard operation
hive copied to clipboard

simulators/ethereum/engine: `BlockBy*` requests are failing for some clients due to blobs missing `v` field

Open marioevz opened this issue 2 years ago • 1 comments

According to https://ethereum.github.io/execution-apis/api-documentation/, transaction json format that is returned by eth endpoints that return blocks must follow the format of eth_getTransactionByHash, which, starting on blob transactions, contain only the yParity value and not the v value.

Currently hive is complaining as follows:

Unexpected error on BlockByNumber: missing required field 'v' in transaction

This should not be an issue and the test should be looking for yParity instead, or, at the very least, accept either field (v or yParity).

marioevz avatar Nov 16 '23 14:11 marioevz

Opened a PR https://github.com/ethereum/go-ethereum/pull/28564 to start addressing this, and once it makes it into master we can update the dependency in the simulator.

marioevz avatar Nov 20 '23 18:11 marioevz

Should be fixed by now.

fjl avatar Jul 15 '24 12:07 fjl