Felix Lange

Results 442 comments of Felix Lange

I looked into your draft PR to remove the accessor methods, and we should get those changes in here as well.

I've rebased this, and have done some more renames.

It's in! I added a bit of historical context to the commit message. > Here, the core.Message interface turns into a plain struct. > > This is a breaking change...

Sorry I didn't respond to this earlier. I'm not fundamentally opposed to adding support for named parameters, but the way it's done here is not good. In order to use...

We could also simply change the PrecompiledContract interface to have a `Run(CallContext) []byte` method instead of `Run([]byte) []byte`.

Sorry for the late review. This function seems very specific to your use case and we won't add it in package crypto.

Just noting here that this is a compatibility-breaking change. We've been returning hex-encoded strings from graphql for years, so there will likely be issues in some client software trying to...

@s1na is in charge of the spec, so he'll be able to make a good decision here.

The API specification (https://github.com/ethereum/execution-apis) was created only very recently, and we literally copied the existing GraphQL schema there without changing it. It would be good to get to the point...

Discussion result: Going back to the spec, we find that the definition of `Long` does not explicitly state the scalar type. It can be interpreted to mean that Long values...