Felix Lange

Results 442 comments of Felix Lange

The abi package already has a more correct way of decoding reverts: ```go var revertData []byte id := [4]byte(revertData[:4]) errorType, err := abi.ErrorByID(id) if err != nil { return err...

To get the `revertData` from JSON-RPC in Go, do this: ```go func revertData(err error) ([]byte, bool) { var ec rpc.Error var ed rpc.DataError if errors.As(err, &ec) && errors.As(err, &ed) &&...

There is no need to match the errors of besu. I know we are checking these on hive, but the place to fix that is hive. What's most important is...

I like @s1na's idea to not allow `toBlock` for subscription queries. The problem with using our subscription model is that there is no way for the server to signal the...

@vdamle your `processLogs` loop needs to exit on the first message received from the error channel.

The tool is actively maintained! The behavior looks like a bug in CLI parsing logic. The crawl command accepts the --bootnodes flag, so it should be detected.

I have been reading the code for a good while now, and it's good in general. But there is a small issue: when the CL doesn't provide the necessary APIs,...

For reference, I was only ever able to run this using `https://www.lightclientdata.org`. It seems the required functions are not provided by CLs by default.

I was actually wondering about that. So we need to update the block representation every time there is a beacon chain fork, even if we don't specifically rely on newer...

Ahh, I guess it's also because of Engine API versioning.